[Konsole-devel] Review Request: Copy Bottom line of screen if it isn't a newline

[Gu Rui]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102567/#review6438
-----------------------------------------------------------


I don't think this is the right fix. The "lines += 1;" violate the semantics of variable "lines". I think the https://git.reviewboard.kde.org/r/102177/ is the right fix. I will post the reason why I think it is right there.

- Gu


On Sept. 10, 2011, 4:59 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102567/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2011, 4:59 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> If bottom line of screen has a trailing newline after resizing, screenLines[lines-1] is empty and then, it isn't necessary to copy it
> on newScreenLines. Otherwise you have to copy it.
> 
> Close the bug 192221
> 
> 
> This addresses bug 192221.
>     http://bugs.kde.org/show_bug.cgi?id=192221
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp 502360b 
> 
> Diff: http://git.reviewboard.kde.org/r/102567/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110912/e52501d4/attachment.html>