[Konsole-devel] Review Request: ANSI escape code "\e[1; 93m" should result intensive color instead of normal color

[Jekyll Wu]

> On Sept. 9, 2011, 3:16 a.m., Kurt Hindenburg wrote:
> > It doesn't appear to fix the bug report issue.  I get 
> > yellow, yellow, yellow
> > orange, orange, yellow
> > 
> > echo -e "\e[93m YELLOW \e[0m \e[4;93m UNDERLINED \e[0m \e[1;93m BOLD \e[0m" &&
> > echo -e "\e[33m ORANGE \e[0m \e[4;33m UNDERLINED \e[0m \e[1;33m BOLD \e[0m"

Yes, this only fixes the wrong color in the first line. 

As for the second line, I think that is the expected behavior. Bold + normal color ==> intensive color .


- Jekyll


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102554/#review6343
-----------------------------------------------------------


On Sept. 8, 2011, 12:39 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102554/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2011, 12:39 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
>   
> The current behavior is bold(1) will toggle the intensity of an intensive color(93), So the result is normal color. This is counter-intuitive. Xterm, rxvt-unicode and vte-based emulators behave as described in the summary, So I think konsole should also behave that way.
> 
> 
> This addresses bug 274603.
>     http://bugs.kde.org/show_bug.cgi?id=274603
> 
> 
> Diffs
> -----
> 
>   src/CharacterColor.h 3181073 
>   src/Screen.cpp 502360b 
> 
> Diff: http://git.reviewboard.kde.org/r/102554/diff
> 
> 
> Testing
> -------
> 
> No issue noticed so far. I am really not very sensitive to colors in terminal process.
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110909/13e440c9/attachment.html>