[Konsole-devel] Review Request: When using RTL interface, do not make terminal emulator RTL

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102976/
-----------------------------------------------------------

(Updated Oct. 26, 2011, 9:50 p.m.)


Review request for Konsole.


Changes
-------

The inline test text seems corrupted, so upload a file instead


Description
-------

Konsole does contain the code for forcing LTR in the terminal area :

    QWidget::setLayoutDirection(Qt::LeftToRight);

However, according to the Qt doc[1], that method does not influence text layout direction anymore since Qt-4.7. So this problem is basically a regression caused by upstream change. I am not sure about that statement because I have never used RTL before and have no idea how konsole behaved with old version of Qt.

One solution is to force QPainter to use LTR when drawing text. This is what this patch does.

Since I am definitely no expert on this RTL issue, please do not take above analysis too seriously. Is there any expert we can refer to?


This addresses bug 279084.
    http://bugs.kde.org/show_bug.cgi?id=279084


Diffs
-----

  src/TerminalDisplay.cpp 46c6438 

Diff: http://git.reviewboard.kde.org/r/102976/diff/diff


Testing (updated)
-------

Using the attached text for basic testing. The result seems OK to me when forcing LTR to the terminal area

And according to the the bug reporter who seems to use Hebrew as native language, the patch solves the problem and no regression is observed so far.


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111026/675a2165/attachment.html>