[Konsole-devel] [Bug 227114] Confusing konsole scrollback settings

[Jekyll Wu]

https://bugs.kde.org/show_bug.cgi?id=227114


Jekyll Wu <adaptee at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
   Version Fixed In|                            |4.8
         Resolution|                            |FIXED




--- Comment #5 from Jekyll Wu <adaptee gmail com>  2011-10-25 11:45:58 ---
Git commit 8f7be18a64cfb5a25f87d0348eb48566cbd6d4e8 by Jekyll Wu.
Committed on 25/10/2011 at 10:53.
Pushed by jekyllwu into branch 'master'.

Simplify the scrollback setting dialog to avoid potential confusion.

  - the change is not saved into profile and only influences current tab
  - remove the 'Save to current profile' checkbox
  - remove the 'Defaults' button
  - change dialog title from "Scrollback Options" to "Adjust Scrollback"
  - change action from "Scrollback Options..." to "Adjust Scrollback..."

The new dialog makes the "Adjust Scrollback..." action more consistent with
most
of other actions in the context menu, since they only influence or work in the
context of current tab.

The UI change is not quite satisfactory. Feel free to refine the UI part
to make it more clear and elegant.

BUG: 227114
FIXED-IN : 4.8
REVIEW: 102688

M  +2    -2    desktop/partui.rc
M  +2    -2    desktop/sessionui.rc
M  +7    -42   src/HistorySizeDialog.cpp
M  +1    -27   src/HistorySizeDialog.h
M  +6    -24   src/SessionController.cpp
M  +1    -1    src/SessionController.h

http://commits.kde.org/konsole/8f7be18a64cfb5a25f87d0348eb48566cbd6d4e8

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.