[Konsole-devel] Review Request: Make 'Shift+Insert" work in embedded terminal(konsole kpart) by default

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102924/#review7513
-----------------------------------------------------------

Ship it!


>From a Dolphin point-of-view this patch is fine. I cannot judge whether from the perspective of the terminal-interface this patch is more a workaround or just a pragmatic solution, but judging from the recent commits you seem to maintain konsole anyhow so it's on you to decide :-) Thanks for taking care of this issue!

- Peter Penz


On Oct. 20, 2011, 9:50 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102924/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2011, 9:50 a.m.)
> 
> 
> Review request for Konsole and Peter Penz.
> 
> 
> Description
> -------
> 
> When 'Shift+Insert' is pressed, konsole currently sends the 'overrideShortcutCheck(bool&)' signal to ask higher level whether this key combination should always go into the terminal process (thus overriding shortcut).
> 
> In stand-alone konsole, the higher level never answer such question, so the key combination may be intercepted as shortcut.
> 
> The konsole kpart, however, answers such question as: " such key combination should always go into terminal process". Of course, the host apps can override that decision. The unfortunate fact is most host apps do not. AFAIK, yakuake is the only host app which answer this question itself. So dolphin, kate, okteta, an kdevelop all suffer from this 'Shift+Insert' problem, while yakuake does not.
> 
> The problem has at least two solutions:
> 
> 1). konsole code treats "Shift+Insert" specially, since that is conventionally used as the shortcut for pasting and deserves such special treatment. That is what this patch does.
> 
> 2). All host apps answer that question themselves, and treat Shift+Insert specially there. I guess most host apps just do not like this solution.
> 
> 
> This addresses bug 165720.
>     http://bugs.kde.org/show_bug.cgi?id=165720
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp 54abc14 
> 
> Diff: http://git.reviewboard.kde.org/r/102924/diff/diff
> 
> 
> Testing
> -------
> 
> 'Shift+Insert' works in dolphin,kate,okteta,kdevelop. No regression observed so far
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111020/6d70dfa7/attachment.html>