[Konsole-devel] Review Request: Avoid adding extra trailing space when copying text

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102906/
-----------------------------------------------------------

(Updated Oct. 18, 2011, 4:25 p.m.)


Review request for Konsole.


Changes
-------

previous patch forgets one important line


Description
-------

This patch is basically based upon the patch from comment #94 in bug #188528. 

As noted in the code comment, the added 'isRealCharacter' boolean  field can be furthur improved to become a enum field to indicate more roles:

   *    RealCharacter: a character which really exists
   *    PlaceHolderCharacter: a character which exists as place holder
   *    TabStopCharacter: a special place holder for HT('\t')

I think that 'TabStopCharacter' will make it possible to copy HT('\t') as it is in the future(bug #168368).
However, I have not figured out the how konsole exactly deals with HT('\t') so just leave that field as boolean for now. 


This addresses bugs 188528 and 254628.
    http://bugs.kde.org/show_bug.cgi?id=188528
    http://bugs.kde.org/show_bug.cgi?id=254628


Diffs (updated)
-----

  src/Character.h 56df4b4 
  src/Screen.cpp 4daa371 
  src/TerminalCharacterDecoder.cpp 1866df7 

Diff: http://git.reviewboard.kde.org/r/102906/diff/diff


Testing
-------

I used the alpine example for testing. The result seems fine and no regressio is observed so far. If there is regression I haven't noticed, I guess it might be 'TAB'('\t') related.


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111018/d0da3954/attachment.html>