[Konsole-devel] Review Request: Konsole requires integer font metrics

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102899/#review7445
-----------------------------------------------------------


This review has been submitted with commit de5ef9484a253795002d0e6accc86cc3cb1b5c71 by Christoph Feck to branch master.

- Commit Hook


On Oct. 17, 2011, 9:27 a.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102899/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2011, 9:27 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> As can be seen on the screenshot at https://bugreports.qt.nokia.com/browse/QTBUG-22040 Konsole fails to render correctly with Qt 4.8, because of the non-integer font-metrics.
> 
> I found QFont::ForceIntegerMetrics StyleStrategy, which had already been added with Qt 4.7, and Konsole should set this flag, unless you plan to rewrite the complete cell positioning code.
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.cpp d76b9bd 
> 
> Diff: http://git.reviewboard.kde.org/r/102899/diff/diff
> 
> 
> Testing
> -------
> 
> Works like a charm with both Qt 4.7, as well as Qt 4.8.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111017/843f23c0/attachment.html>