[Konsole-devel] Review Request: Draw unable-to-simulate line characters in the normal way, i.e., using the glyph provided by font

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102836/#review7438
-----------------------------------------------------------


This review has been submitted with commit c53d790f31d7a23e59b37b44c4529ae8229e8204 by Jekyll Wu to branch master.

- Commit Hook


On Oct. 12, 2011, 2:05 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102836/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2011, 2:05 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Currently konsole draw most line characters itself, instead of using the glyph provided by font. Unfortunately, the model of 5x5 pixel matrix can't be used to simulate and draw a few of them. So the result is those chracters are not drawn, leaving whitespace in its place.
> 
> The patch simply reduce the range of line charaters to the actually supported set. So those unsupported line characters are drawn in the normal way of using the glyph provided by font. 
> 
> This is more like workaround than solution, but I think it is bettern than current situation.
> 
> 
> This addresses bug 210329.
>     http://bugs.kde.org/show_bug.cgi?id=210329
> 
> 
> Diffs
> -----
> 
>   src/Character.h 9fde2ee 
>   src/TerminalDisplay.cpp b416f41 
> 
> Diff: http://git.reviewboard.kde.org/r/102836/diff/diff
> 
> 
> Testing
> -------
> 
> Use comment #4 of bug #210329 as a simple test. Seems fine, no regression observed so far.
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111017/b8fee601/attachment.html>