[Konsole-devel] Review Request: Add the missing "seconds to detect silence" setting

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102823/
-----------------------------------------------------------

(Updated Oct. 11, 2011, 4:45 a.m.)


Review request for Konsole.


Changes
-------

- put 'Tab Monitoring' below existing groups
- change the description to 'Seconds to detect silence:'
- reduce the maximum value of spinner from 36000s to 3600s( 1 hour should be long enough)
- remove extraeous changes in .ui file


Description
-------

The title has said enough. 

The main problem is : Is the UI clear enough?  I found it not easy to express clearly what this option does in limited words.


This addresses bug 195978.
    http://bugs.kde.org/show_bug.cgi?id=195978


Diffs (updated)
-----

  src/EditProfileDialog.ui b5471d5 
  src/EditProfileDialog.h 3f62baf 
  src/EditProfileDialog.cpp 7a23374 
  src/Profile.h e06cba4 
  src/Profile.cpp d9706d1 
  src/SessionManager.cpp 7855770 

Diff: http://git.reviewboard.kde.org/r/102823/diff/diff


Testing
-------


Screenshots (updated)
-----------

initial version
  http://git.reviewboard.kde.org/r/102823/s/287/
update version
  http://git.reviewboard.kde.org/r/102823/s/288/


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111011/120c7281/attachment.html>