[Konsole-devel] Review Request: Add the missing "seconds to detect silence" setting

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102823/#review7232
-----------------------------------------------------------


KDE3 had "Seconds to detect silence:  10"; that seems better.  Was there a reason you put it in the center?  I'm not sure if it should be alphabetic or by likelihood of usage (on bottom if that).

You ui diff has some extraneous changes as well.

I haven't tested the code yet.

- Kurt Hindenburg


On Oct. 10, 2011, 11:35 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102823/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2011, 11:35 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The title has said enough. 
> 
> The main problem is : Is the UI clear enough?  I found it not easy to express clearly what this option does in limited words.
> 
> 
> This addresses bug 195978.
>     http://bugs.kde.org/show_bug.cgi?id=195978
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 3f62baf 
>   src/EditProfileDialog.cpp 7a23374 
>   src/EditProfileDialog.ui b5471d5 
>   src/Profile.h e06cba4 
>   src/Profile.cpp d9706d1 
>   src/SessionManager.cpp 7855770 
> 
> Diff: http://git.reviewboard.kde.org/r/102823/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102823/s/287/
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111011/630dd6ec/attachment.html>