[Konsole-devel] Review Request: Make sure the default-profile/favorites/shortcuts settings are saved into disk when logging out KDE

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102781/#review7141
-----------------------------------------------------------


This review has been submitted with commit ae44eb4c4b552f60572cf86402674a2936651594 by Jekyll Wu to branch master.

- Commit Hook


On Oct. 5, 2011, 12:54 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102781/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2011, 12:54 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The patch simply calls the sync() method to ensure default-profile/favorites/shortcuts settings are written into disk when logging out KDE with konsole still running. I'm not sure this is the right or elegant fix, but it works. Submit it here so that some better fix can be suggested by reviews, since this bug is not hard to reproduce and investigate.
> 
> 
> This addresses bug 200987.
>     http://bugs.kde.org/show_bug.cgi?id=200987
> 
> 
> Diffs
> -----
> 
>   src/SessionManager.cpp 05fd9fa 
> 
> Diff: http://git.reviewboard.kde.org/r/102781/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111006/dcc7695a/attachment.html>