[Konsole-devel] Review Request: Add dbus method for enlarging/shrinking the font size of active session

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102769/#review7083
-----------------------------------------------------------


Shouldn't this be under the /Sessions/# ?  I don't think putting session stuff under /Konsole is good.

- Kurt Hindenburg


On Oct. 4, 2011, 9:25 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102769/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2011, 9:25 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The patch is extracted from the mailist[1] with minor fix for name mismatching. Submit it here for the author.
> 
> ------------------------------------------------------------------------
> 
> Hello,
> 
> is it possible to alter session font size via dbus (what can be done using
> Ctrl++ and Ctrl+-, Menu-View-Enlarge Font, etc)? Nothing like that is listed
> among Session methods, I wonder if there is any other way to do that.
> 
> Not having found anything on this, I looked into the code, would something
> like the attached patch be acceptable?
> 
> Thanks
> Michal
> ------------------------------------------------------------------------
> 
> [1] http://lists.kde.org/?l=konsole-devel&m=131714365717285&w=2
> 
> 
> Diffs
> -----
> 
>   src/SessionController.h 46d8c35 
>   src/ViewManager.h aaebad0 
>   src/ViewManager.cpp 2ae7099 
> 
> Diff: http://git.reviewboard.kde.org/r/102769/diff/diff
> 
> 
> Testing
> -------
> 
> qdbus org.kde.konsole /Konsole org.kde.konsole.Konsole.enlargeSessionFont 
> qdbus org.kde.konsole /Konsole org.kde.konsole.Konsole.shrinkSessionFont
> 
> Seems fine.
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111004/f5d5758a/attachment.html>