[Konsole-devel] Review Request: SessionManager should always read/write config entries from/to konsolerc, instead of <hostApp>rc

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102756/#review7060
-----------------------------------------------------------


" I guess the design intention is to allow konsole and host apps have independent settings for favorites/shortcuts"

Yes I believe that was the case.  I could see wanting different profiles visible for konsole versus yakuake/kdevelop/etc.  Do you really think no on else would?

I also don't see any issues w/ allowing kparts to open the 'manage profile' dialog.  If they can edit any of konsole's profiles, why not add/etc them?

I'm open to what other people think...

- Kurt Hindenburg


On Oct. 2, 2011, 3:15 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102756/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2011, 3:15 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The first problem(bug #251062) is SessionManager always read the 'DefaultProfile' entry from konsolerc, but always write that entry into <App>rc. That makes no difference when using konsole directly. But when konsole is used through the kpart way, It causes reported problem. I think this inconsistent read/write must be corrected.
> 
> The second problem(bug #257708) is SessionManager always read/write the Favorites/Shortcuts entries from <App>rc, instead of the konsolerc. Again, when konsole is used through the kpart way, it causes confusion. I guess the design intention is to allow konsole and host apps have independent settings for favorites/shortcuts. But I feel that is over design.Most apps and users only expect/need konsole kpart to provide an plain embedded terminal where a shell is ready for use. They do not need/care the ability to open a new session with some favorite profile using some shortcut.
> 
> A related but bigger question is : Is it necessary for konsole kpart to provide the action for opening the ManageProfilesDialog? As mentioned above, 'Favorites' does not make much sense for host apps and 'Shortcuts' is already hidden. And AFAIK the only host app which actually uses that action is yakuake. 
> 
> 
> This addresses bugs 251062 and 257708.
>     http://bugs.kde.org/show_bug.cgi?id=251062
>     http://bugs.kde.org/show_bug.cgi?id=257708
> 
> 
> Diffs
> -----
> 
>   src/SessionManager.cpp 38bc703 
> 
> Diff: http://git.reviewboard.kde.org/r/102756/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20111003/188c9395/attachment.html>