[Konsole-devel] Re: Review Request: Correct issue where spaces are copyable.

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100913/
-----------------------------------------------------------

(Updated March 22, 2011, 3:35 p.m.)


Review request for Konsole.


Changes
-------

Only use defaultChar when scrolling up/down.  Otherwise, apps that use spaces to color the background won't work (ie mc).


Summary
-------

This fixes the issue where spaces are copyable at the end of lines
when the foreground or background colors are non-default.
tput setf 1

 When clearing with ' ', the defaultChar will be used.
This will cause the lines to be resized (getting rid of the spaces).


This addresses bug 188528.
    http://bugs.kde.org/show_bug.cgi?id=188528


Diffs (updated)
-----

  src/Screen.cpp 41df71679b464d4fb78c06496308e6fc1e82ba17 

Diff: http://git.reviewboard.kde.org/r/100913/diff


Testing
-------

work when using 'tput setf #' and 'tput setb #'
and in  vim ":hi normal ctermbg=white'


Thanks,

Kurt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110322/1ebefddb/attachment.html>