[Konsole-devel] Re: Review Request: Restore codec to profile setting or previous codec upon reset

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101565/#review4137
-----------------------------------------------------------


This review has been submitted with commit 27182ebbadb8bcf406cba74be1888125e54fe63f by Kurt Hindenburg to branch master.

- Commit


On June 10, 2011, 1:54 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101565/
> -----------------------------------------------------------
> 
> (Updated June 10, 2011, 1:54 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Also bug 273959
> 
> After typing in 'reset' or using 'Clear Scrollback & Reset', the current codec is lost.
> 
> with this patch, typing in 'reset' will cause the codec to stay what it was before the reset.  Using the 'Clear Scrollback & Reset' will cause the codec to be set to the Profile setting.
> 
> I didn't see an easy way for the Emulation.cpp/VT102Emulation to find the profile setting so the 2 methods of reset have different outcomes.
> 
> 
> This addresses bug 123866.
>     http://bugs.kde.org/show_bug.cgi?id=123866
> 
> 
> Diffs
> -----
> 
>   src/SessionController.cpp 9eb06c663e9b6b52f1de481fb090c3a5a2b6c772 
>   src/Vt102Emulation.cpp 66072665cb405473b81c96e94f79be00ed6fa78c 
> 
> Diff: http://git.reviewboard.kde.org/r/101565/diff
> 
> 
> Testing
> -------
> 
> Trunk using utf-8 and 8859-1 to testing.
> 
> 
> Thanks,
> 
> Kurt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110625/a0f8546c/attachment.html>