[Konsole-devel] Re: Review Request: Add support for Unicode decomposed text in Konsole

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101721/
-----------------------------------------------------------

(Updated June 21, 2011, 10:52 p.m.)


Review request for Konsole, Eike Hein, Kurt Hindenburg, and Thiago Macieira.


Summary
-------

If you want to write an e with a ring, as there is no unicode character for it, you have to use e + ring combining character, this patch makes use of the unused/unfinished feature of RE_EXTENDED_CHAR to be able of actually storing more than a quint16 in each position of the terminal without changing the code too much


This addresses bug 96536.
    http://bugs.kde.org/show_bug.cgi?id=96536


Diffs
-----

  src/Character.h 4088def 
  src/Emulation.cpp f52f7e8 
  src/Screen.h ba99145 
  src/Screen.cpp 41df716 
  src/SessionManager.h ccca52b 
  src/SessionManager.cpp 0db05cd 
  src/TerminalCharacterDecoder.cpp cd05f65 
  src/TerminalDisplay.h 61de038 
  src/TerminalDisplay.cpp 5f6478f 

Diff: http://git.reviewboard.kde.org/r/101721/diff


Testing (updated)
-------

Played for it for a while, checked i can copy, paste add characters, it's stored in the history, i can have a full terminal with e with ring. Here you have a file few e with ring so you can wget and cat it in the old konsole and see how the ring is missing and see how it works once patched http://www.tsdgeos.com/filewitherings.txt


Thanks,

Albert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110621/3bc9b5a0/attachment.html>