[Konsole-devel] [Bug 188528] konsole's history adds spaces to end of lines when copying text

Eugeny Shkrigunov eshkrig at gmail.com
Sat Jul 23 17:54:21 UTC 2011


https://bugs.kde.org/show_bug.cgi?id=188528


Eugeny Shkrigunov <eshkrig at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |eshkrig at gmail.com




--- Comment #88 from Eugeny Shkrigunov <eshkrig gmail com>  2011-07-23 17:54:20 ---
Hi!
Sorry for my English.

There is related problem due typo. To reproduce:
create a file in a few lines
cat << EOF > some_file
some text 1
some text 2
some text 3
some text 4
some text 5
EOF

open konsole
Run command 'cat some_file' until konsole does not scroll the screen contents.
Select multiple lines and paste the selection into a text editor.
Note the trailing spaces.

After applying the patch the problem disappears.

diff -Naur konsole-4.6.5.orig/konsole/src/Screen.cpp
konsole-4.6.5/konsole/src/Screen.cpp
--- konsole-4.6.5.orig/konsole/src/Screen.cpp   2011-02-28 15:50:53.000000000
+0300
+++ konsole-4.6.5/konsole/src/Screen.cpp        2011-07-23 21:21:24.369999782
+0400
@@ -817,7 +817,7 @@

     //if the character being used to clear the area is the same as the
     //default character, the affected lines can simply be shrunk.
-    bool isDefaultCh = (clearCh == Character());
+    bool isDefaultCh = (clearCh == defaultChar);

     for (int y=topLine;y<=bottomLine;y++)
     {

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the konsole-devel mailing list