[Konsole-devel] [Bug 176902] Konsole: apps in tabbed shell truncated to 24 lines (LINES=24)

[Jekyll Wu]

https://bugs.kde.org/show_bug.cgi?id=176902





--- Comment #21 from Jekyll Wu <adaptee gmail com>  2011-07-20 10:44:23 ---
Created an attachment (id=62013)
 --> (http://bugs.kde.org/attachment.cgi?id=62013)
make sure pty device have proper size info 

This bug and #203185 are caused by the same reason: when the terminal
process(shell,vi,mc,etc) starts and queries the pty device about size , the pty
device has not been told of the proper size by konsole. So the initial size ,
0x0, is returned to the terminal process.

The details are not the same :

a). in this bug, SIGNAL(imageSizeChanged()) is not emitted, because the initial
size and default size happens to be the same, 80x40. 

b). in #203185,  SIGNAL(imageSizeChanged()) is emitted, but terminal process
start too quickly so it still gets 0x0. That is a race condition.

The attached patch tries to guarantee that when terminal process starts and
queries the pty device about size, it always get the proper size. It's similar
to martin's patch, but also considers #203185. 

This patch uses a hard-coded delay, which is not elegant but works well in
practice. Feel free to make any modification to it.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.