[Konsole-devel] Re: Review Request: Enable Profile Dialog's Apply button only when profile has been changed.

Commit Hook null at kde.org
Sat Jul 16 15:46:54 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101904/#review4749
-----------------------------------------------------------


This review has been submitted with commit ecfb037c27b84e38b2a1a4d6c3974a4505434be7 by Kurt Hindenburg to branch master.

- Commit


On July 9, 2011, 9:28 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101904/
> -----------------------------------------------------------
> 
> (Updated July 9, 2011, 9:28 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Keep track of any changes to the Profile and only enable the Apply button when something has really changed.
> 
> Patch by Jekyll Wu adaptee at gmail.com
> 
> Might backport to 4.7 if there are no concerns.
> 
> 
> This addresses bug 274501.
>     http://bugs.kde.org/show_bug.cgi?id=274501
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h f14aec6 
>   src/EditProfileDialog.cpp 747d277 
> 
> Diff: http://git.reviewboard.kde.org/r/101904/diff
> 
> 
> Testing
> -------
> 
> Appears to work as described AFAIK
> 
> 
> Thanks,
> 
> Kurt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110716/51a4353a/attachment.html>


More information about the konsole-devel mailing list