[Konsole-devel] [Bug 274501] Konsole's profiles apply buttons are always active

Jekyll Wu adaptee at gmail.com
Fri Jul 8 16:27:59 UTC 2011


https://bugs.kde.org/show_bug.cgi?id=274501


Jekyll Wu <adaptee at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61703|0                           |1
        is obsolete|                            |




--- Comment #10 from Jekyll Wu <adaptee gmail com>  2011-07-08 16:27:58 ---
Created an attachment (id=61710)
 --> (http://bugs.kde.org/attachment.cgi?id=61710)
apply button should be active only when these is really modification

(In reply to comment #9)
> #8, I would guess because you are comparing QFonts.  I'm find w/ committing it w/ this issue if that is the only one found.   Also, you can remove the include for KPushButton and try to watch the whitespace-only changes.  Thanks.

Extra #include and whitespace changnes are removed. Also, the internal method
is renamed for consistency.

The code does compare QFont, but it is only because the object within QVariant
happens to be QFont. If I did not misunderstand, does your reply imply unless
extra specific code is added to deal with the comparison between QFonts, that
weird issue can not be solved?

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the konsole-devel mailing list