[Konsole-devel] [Bug 168539] screen's 'power detach' function causes bash to crash.

[michel kollenhoven]

https://bugs.kde.org/show_bug.cgi?id=168539





--- Comment #9 from michel kollenhoven <kde-bugs brainpower no-ip org>  2011-02-24 11:34:56 ---
hi i have a sipmle patch could somebody fix and commit for me?

see:
https://projects.kde.org/projects/kde/kdebase/konsole/repository/revisions/master/entry/src/Session.cpp#L777


org
---8<----
  if (!_wantedClose || exitStatus != 0)    
  {    
    if (_shellProcess->exitStatus() == QProcess::NormalExit)    
        message = i18n("Program '%1' exited with status %2.", _program,
_shellProcess->exitStatus());
    elseif (_shellProcess->exitStatus() > 127)
        message = i18n("Program '%1' receved signal '%2', _program,
convertToSignalName(exitStatus-128);
        //according to man bash
    else    
        message = i18n("Program '%1' crashed.", _program);

    //FIXME: See comments in Session::monitorTimerDone()    
    KNotification::event("Finished", message , QPixmap(),    
                         QApplication::activeWindow(),    
                         KNotification::CloseWhenWidgetActivated);    
  }        
  if ( !_wantedClose && _shellProcess->exitStatus() != QProcess::NormalExit &&
_shellProcess->exitStatus() !> 127)    
      terminalWarning(message);    
  else
        emit finished();    
}
--->8---
ok convertToSignalName() is a non exisitant function but should do the same as
kill -l $num
i am unsure if i need to use _shellProcess->exitStatus() or exitStatus

b.t.w. i have verified (see link) that konsole  source is the problem of this
message and my previus message is true

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.