[Konsole-devel] Review Request: Set correct focus in the "rename tab" dialog

Sun Feb 13 03:25:30 UTC 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100642/
-----------------------------------------------------------

Review request for Konsole.

Summary
-------

If a tab is renamed (e.g. via right click->rename tab) the edit widget is not                                                                                                  
focused (instead the Ok button gets the focus).  This patch changes this                                                                                                       
behavior.  Now the focus is set depending on the connection type (local or                                                                                                     
remote).                                                                                                                                                                       

The RenameTabsDialog gets two new functions to set the focus to the respective                                                                                                 
edit widget.  The Session provides a method to query if it is a remote session.                                                                                                
Finally the SessionController uses these methods to focus the right widget.

Diffs
-----

  src/RenameTabsDialog.h 734f270 
  src/RenameTabsDialog.cpp 2ecd417 
  src/Session.h de78951 
  src/Session.cpp d1834db 
  src/SessionController.cpp cdfa66e 

Diff: http://git.reviewboard.kde.org/r/100642/diff

Testing
-------

Thanks,

Sebastian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110213/5890b931/attachment.html>