[Konsole-devel] [Bug 188528] konsole's history adds spaces to end of lines when copying text

[tomasb at kapsa.cz]

https://bugs.kde.org/show_bug.cgi?id=188528


tomasb at kapsa.cz changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomasb at kapsa.cz




--- Comment #96 from  <tomasb kapsa cz>  2011-08-25 13:20:47 ---
(In reply to comment #95)
> > At first, it was not working in mc, because _includeTrailingWhitespace was
> > wrongly set, so it wasn't removing empty line ending in mcedit. Secondly,
> > because newline char was at the line end after spaces, it wasn't removing
> > anything.
> 
> mc works fine: I applied the patch
> https://bugs.kde.org/show_bug.cgi?id=188528#c80
> https://bugs.kde.org/show_bug.cgi?id=188528#c88

I was talking about a piece of code in PlainTextDecoder::decodeLine, which is
affected by my suggested patch, not about the patch from comment 80. Patch from
comment 80 deletes all spaces from end of line without distinguishing whetever
they should or slould not be here.

You can test it - make a file with one word, five spaces and linefeed. Cat file
in konsole and copy and paste output to editor. In editor you should see word
and five spaces. Patch from comment 80 deletes all spaces, so you will se only
word alone. Unpatched konsole adds additional spaces to fill whole line. My
patch deals with that AFAIK correctly.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.