[Konsole-devel] Review Request: Do not (sometimes) delete the bottom line of screen after resizing

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102177/#review5776
-----------------------------------------------------------


It looks like this code has been in since 4.0.  The code in 3.5.8 doesn't have it although the classes/structure changed a lot in 4.0.  I'm not sure why the +1 is used on new image sizes.

- Kurt


On Aug. 2, 2011, 6:51 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102177/
> -----------------------------------------------------------
> 
> (Updated Aug. 2, 2011, 6:51 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch eliminate the problem described in comment #1 of bug #192221. However,  I am not sure that patch is really correct and would not cause new problems, because I do not quite understand why the Screen class always allocate spaces for N+1 lines when it is set to has N lines.
> 
> 
> This addresses bug 192221.
>     http://bugs.kde.org/show_bug.cgi?id=192221
> 
> 
> Diffs
> -----
> 
>   src/Screen.cpp ecd1642 
> 
> Diff: http://git.reviewboard.kde.org/r/102177/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110817/bff5ee09/attachment.html>