[Konsole-devel] Review Request: Newly created container should also show new & close button.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102324/#review5698
-----------------------------------------------------------


This review has been submitted with commit f4b188658dd0d3142fbf2a61b770f08ef802cb30 by Jekyll Wu to branch master.

- Commit


On Aug. 14, 2011, 10:54 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102324/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2011, 10:54 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> I do not know whether the behavior described in #207213 is an intended behavior. Is it by design that only one container should show the new & close button ? Even so, current behavior is still broken because once the initial container is closed, the new & close button does not show any more.
> 
> This patch depends on another review : 102321. 
> 
> If no objection, I will commit both sometime later.
> 
> 
> This addresses bug 207213.
>     http://bugs.kde.org/show_bug.cgi?id=207213
> 
> 
> Diffs
> -----
> 
>   src/ViewManager.cpp 66041a3 
> 
> Diff: http://git.reviewboard.kde.org/r/102324/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110815/c8252ca0/attachment.html>