[Konsole-devel] Review Request: Allow Konsole to intelligently handle dropped files

[Kurt Hindenburg]

> On July 22, 2010, 8:47 a.m., Frank Roscher wrote:
> > Bump. It's been 10 days and I'm afraid this is being forgotten about :/
> > Is there a specific reason for this not getting any attention (besides a lack of time which of course would be understandable)?
> 
> Kurt Hindenburg wrote:
>     In general it looks OK - let me look at it further and I'll get it in for 4.6.  using the KonqOperations appears to make this rather simple.
> 
> Jekyll Wu wrote:
>     It seems this has really be forgotten :)

Yes, sorry about missing this.  It is unfortunate that SessionController has to be linked to get the currentDir.

Also, the copy/move fails on remote directories (ssh, etc).  A check or warning needs added.


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/4600/#review6662
-----------------------------------------------------------


On July 11, 2010, 3:55 p.m., Frank Roscher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/4600/
> -----------------------------------------------------------
> 
> (Updated July 11, 2010, 3:55 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> With this patch Konsole creates a popup menu when a file from e.g. Dolphin has been dragged'n'dropped to it.
> The popup menu allows to Copy, Move or Link the file into the current working directory or to simply paste its URL as text (the latter being the current behaviour in KDE4).
> 
> The popup is created using the same method that is used by dolphin, so there shouldn't be any concern about code duplication.
> I'm not quite sure if this is the most elegant solution, especially with regard to my use of the sender() method. Please enlighten me if there's a better way :)
> 
> There was a (different) implementation for this back in KDE3 times; there's also a pretty popular wishlist item on the KDE forums.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt 1148641 
>   trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1148641 
>   trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.h 1148641 
>   trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1148641 
> 
> Diff: http://svn.reviewboard.kde.org/r/4600/diff
> 
> 
> Testing
> -------
> 
> All possible operations in the popup with files and folders; local as well as over SFTP, single files as well as multiple files at once.
> Dropping simple text still works, as well.
> But I do tend to miss obvious stuff sometimes.
> 
> 
> Screenshots
> -----------
> 
> Popup menu
>   http://svn.reviewboard.kde.org/r/4600/s/456/
> 
> 
> Thanks,
> 
> Frank
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110809/fe8de3c1/attachment.html>