[Konsole-devel] Review Request: Do not emit keyPressedSignal when QInputMethodEvent::commitString() is empty.

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102248/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

When user switches focus (even using mouse) between tabs/windows of konsole, ibus will trigger inputMethodEvent(). Most of the time commitString() will be empty. Do not emit keyPressedSignal in such case, otherwise konsole will scroll active view to bottom. See bug #236733.

The side effect is when inputmethod is activated, the active view will not scroll to bottom on keystroke until user has committed some string.


This addresses bug 236733.
    http://bugs.kde.org/show_bug.cgi?id=236733


Diffs
-----

  src/TerminalDisplay.cpp 6006b4a 

Diff: http://git.reviewboard.kde.org/r/102248/diff


Testing
-------


Thanks,

Jekyll

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110807/346d0bc3/attachment.html>