[Konsole-devel] Review Request: Allow applications hosting the Konsole KPart to monitor for silence and activity

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102223/#review5414
-----------------------------------------------------------


As requested, the Yakuake side of things is now available for testing from a feature branch in yakuake.git, named feature-activity-and-silence-monitoring.

See the tab context menu to toggle monitoring. It's a single toggle action per type for tabs hosting a single terminal; for a tab hosting multiple (see the split options in the same context menu) it morphs into a sub-menu allowing toggling for all or individual terminals, highlighting the respective terminal as the menu actions are hovered.

The notification events can be configured from the usual "Configure Notifications" dialog, found from the Yakuake menu (the middle of the three buttons in the bottom-right corner of the window).

Note that much like Konsole, Yakuake takes care not to spam multiple activity notifications in short order. Only one notification for activity is shown, unless (a) monitoring is disabled and reenabled or (b) the active tab is switched or (c) the window is closed.

The Yakuake side is reasonably complete now, possibly pending some cleanup and version checks once the Konsole side is merged.

- Eike


On Aug. 5, 2011, 1:35 p.m., Eike Hein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102223/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2011, 1:35 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The purpose of this patch is to allow applications hosting the Konsole KPart to tap into Konsole's ability to monitor terminals for silence or activity.
> 
> To accomplish this, Part has seen the addition of two slots, each taking a bool argument, to toggle the monitoring for silence or activity, respectively. Once and only if monitoring is enabled for an event type, a corresponding newly-added signal is emitted by Part.
> 
> Repeated calls to enable monitoring are handled by means of Qt::UniqueConnection. As the KPart internally has the notion of supporting multiple sessions, but this is not exposed in its API or user interface, the code has been written to toggle monitoring on all sessions by getting the list from SessionManager.
> 
> The use of signals and slots instead of extending the TerminalInterface class may seem strange, but this has ample precedent - there are several such slots and one signal already, which are in active use by applications (e.g. Yakuake).
> 
> The addition of this interface will allow the implementation of a long-standing feature wish by Yakuake users (monitoring for silence/activity).
> 
> Should this patch be accepted I can commit it myself.
> 
> 
> This addresses bug 169650.
>     http://bugs.kde.org/show_bug.cgi?id=169650
> 
> 
> Diffs
> -----
> 
>   src/Part.h f1262dd 
>   src/Part.cpp e70b7e3 
> 
> Diff: http://git.reviewboard.kde.org/r/102223/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eike
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110805/8301902f/attachment.html>