[Konsole-devel] Review Request: add shortcuts to jump to top & bottom of history

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102124/#review5306
-----------------------------------------------------------


This review has been submitted with commit 9cf9557c8f300a00cb89a3b507f1edc98d3bf9d9 by Kurt Hindenburg to branch master.

- Commit


On July 29, 2011, 4:01 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102124/
> -----------------------------------------------------------
> 
> (Updated July 29, 2011, 4:01 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The shortcut of jumping to top of history is for the request of #45950
> 
> The shortcut of jumping to bottom of history is added not only for consistency, but also to be used for #38390, especially its comment #9 and #10. 
> 
> Possible improvement:
> 
> 1). add the two new entries into all .keytab files
> 
> 2). it feel strange that Vt102Emualtion.cpp includes TerminalDisplay.h in order to call its scrolling function. The dependency looks reversed. Maybe it is better that Vt102Emualtion just emit signal containing necessary argument, which (finally) triggers the code in TerminalDisplay to do the scroll operation.
> 
> 
> This addresses bugs 38390 and 45950.
>     http://bugs.kde.org/show_bug.cgi?id=38390
>     http://bugs.kde.org/show_bug.cgi?id=45950
> 
> 
> Diffs
> -----
> 
>   data/keyboard-layouts/default.keytab aebd8cf 
>   src/KeyboardTranslator.h da5ed6c 
>   src/KeyboardTranslator.cpp 5fc95d6 
>   src/Vt102Emulation.cpp c0c2a8b 
> 
> Diff: http://git.reviewboard.kde.org/r/102124/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20110802/74cf27b8/attachment.html>