[Konsole-devel] Review Request: Reimplement the 'Manager Profiles' dialog

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5268/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

This is NOT ready to be imported.  I want to get this off my HD and let others look at it.  Please comment on design,  code,  GUI changes, etc.  For most parts it works as a replacement for the 'manager profiles' dialog.  I still need to go through the code again.

Stuff to do this commit and later:
1. Look at the shortcut delegate - I didn't change much
2. Display profile info in the ksqueezetext line below the table (full file location, permissions of file, etc).
3. In the delete profile, handle if user doesn't have permissions - use new authorize stuff in kdelibs
4. DND - profile order

New dialog:

===========
New...  Edit...  Set as Default  Delete
---
Table
---
Blank ksqueezetext line
----------
        Ok Apply Cancel


Diffs
-----

  /trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt 1171919 
  /trunk/KDE/kdebase/apps/konsole/src/ManageProfilesDialog.h 1171919 
  /trunk/KDE/kdebase/apps/konsole/src/ManageProfilesDialog.cpp 1171919 
  /trunk/KDE/kdebase/apps/konsole/src/ManageProfilesDialog.ui 1171919 
  /trunk/KDE/kdebase/apps/konsole/src/ProfileModel.h PRE-CREATION 
  /trunk/KDE/kdebase/apps/konsole/src/ProfileModel.cpp PRE-CREATION 

Diff: http://svn.reviewboard.kde.org/r/5268/diff


Testing
-------

not enough - eyes crossed


Thanks,

Kurt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20100905/4cfdba25/attachment.html>