[Konsole-devel] Review Request: Adds support for SHELL_SESSION_ID

Wed May 12 05:56:32 UTC 2010

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3045/
-----------------------------------------------------------

(Updated 2010-05-12 05:56:31.863594)

Review request for Konsole.

Changes
-------

Imported QUuid::createUuid, changed to always seed to avoid problems with the color scheme code constantly reseeding with a constant. Added a dbus method to get the SHELL_SESSION_ID.

Summary
-------

Adds support for SHELL_SESSION_ID, re-purposing the apparently unused Session::_uniqueIdentifier as a QUuid.

Session data appears to be stored via KMainWindow::saveGlobalProperties instead of saveProperties, and I think this causes the Uuid field to be copied between like-numbered sessions when one instance has a Uuid and one does not.

Thoughts?

This addresses bug 156563.
    https://bugs.kde.org/show_bug.cgi?id=156563

Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konsole/src/Session.h 1125717 
  /trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1125717 

Diff: http://reviewboard.kde.org/r/3045/diff

Testing
-------

Thanks,

argonel