[Konsole-devel] Review Request: Some more Konsole menubar changes

[Sascha Peilicke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3875/
-----------------------------------------------------------

(Updated 2010-05-03 15:29:28.918606)


Review request for Konsole, Robert Knight and Kurt Hindenburg.


Changes
-------

Updated diff


Summary (updated)
-------

* Changed some shortcuts to comply better to the scheme CTRL+SHIFT+Foo where other apps would use CTRL+Foo.
  Done for 'New Tab', 'New Window', etc.

* Changed some accelerators to comply to other apps

* Changed new tab submenu slightly, instead of an action 'Default Profile', the default profile is
  highlighted with a bold font and automatically used when CTRL+SHIFT+T is pressed. Also it has the
  favorite emblem set

* The default profile now has the favorite emblem set in the ManageProfilesDialog

* 'Detach View' was changed to 'Detach Current Tab'

* Use KStandardAction for 'Show Menubar' and 'Full Screen Mode'

* 'Character Encoding' action changed to 'Set Encoding' and it gained an icon.

* 'Split View' actions use now '(' and ')' shortcuts, as the original ones clashed with new defaults.

* Removed the action 'Clear and Reset' as it is almost identical to 'Clear History and Reset'. Also it didn't
  always work as expected (bug 206709 ) and had no shortcut. To clear the current view without clearing the 
  scrollback history, issue 'clear' in your $SHELL.

* Changed action 'Clear Scrollback and Reset' to only 'Clear Scrollback'.


Diffs (updated)
-----

  trunk/KDE/kdebase/apps/konsole/desktop/konsoleui.rc 1121952 
  trunk/KDE/kdebase/apps/konsole/desktop/partui.rc 1121952 
  trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 1121952 
  trunk/KDE/kdebase/apps/konsole/src/MainWindow.h 1121952 
  trunk/KDE/kdebase/apps/konsole/src/MainWindow.cpp 1121952 
  trunk/KDE/kdebase/apps/konsole/src/ManageProfilesDialog.cpp 1121947 
  trunk/KDE/kdebase/apps/konsole/src/SessionController.h 1121947 
  trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1121952 
  trunk/KDE/kdebase/apps/konsole/src/SessionManager.cpp 1121947 
  trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1121947 
  trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp 1121947 

Diff: http://reviewboard.kde.org/r/3875/diff


Testing
-------

works fine on trunk r1121643


Thanks,

Sascha