[Konsole-devel] Review Request: A new DBUS command to permanent rename session

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2126/#review4433
-----------------------------------------------------------


You can hit 'Review' button to add comments.

1. Any changes to the session name are lost upon exiting Konsole.
2. I think fixing setTitle() would be better.  See bug 183963
3. In trunk, the *.xml files are not stored but rather generated at compile time.

- Kurt


On 2010-03-07 11:41:11, Marián Kyral wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2126/
> -----------------------------------------------------------
> 
> (Updated 2010-03-07 11:41:11)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch adds a new dbus command to permanent rename session.
> 
> 
> Diffs
> -----
> 
>   /branches/KDE/4.3/kdebase/apps/konsole/src/Session.h 986143 
>   /branches/KDE/4.3/kdebase/apps/konsole/src/Session.cpp 986143 
>   /branches/KDE/4.3/kdebase/apps/konsole/src/org.kde.konsole.Session.xml 986143 
> 
> Diff: http://reviewboard.kde.org/r/2126/diff
> 
> 
> Testing
> -------
> 
> I just upgraded to KDE 4.4.1 and patch applied without problem. Could be committed or let me know, what to improve.
> Thanks.
> 
> BTW: I'm little bit confused, is it correct place to put comments?
> 
> 
> Thanks,
> 
> Marián
> 
>