[Konsole-devel] Review Request: Adds support for SHELL_SESSION_ID

[argonel at gmail.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3045/
-----------------------------------------------------------

(Updated 2010-03-05 03:47:26.282007)


Review request for Konsole.


Changes
-------

To ensure UUIDs are actually unique, added initialization for the _uniqueIdentifier and a check just before the shell is launched.

For ease of use, stripped the QUuid.toString() of the braces and dashes. As for the length, the SHELL_SESSION_ID is meant to be used by scripts not manually, so the length of the value should not be a problem.


Summary
-------

Adds support for SHELL_SESSION_ID, re-purposing the apparently unused Session::_uniqueIdentifier as a QUuid.

Session data appears to be stored via KMainWindow::saveGlobalProperties instead of saveProperties, and I think this causes the Uuid field to be copied between like-numbered sessions when one instance has a Uuid and one does not.

Thoughts?


This addresses bug 156563.
    https://bugs.kde.org/show_bug.cgi?id=156563


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konsole/src/Session.h 1079359 
  /trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1079359 

Diff: http://reviewboard.kde.org/r/3045/diff


Testing
-------


Thanks,

argonel