[Konsole-devel] Review Request: Add option to blur transparent background (utilizing KWin's new blur support).

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4292/#review6315
-----------------------------------------------------------


BUG 198175 - Fredrikh sent me a patch that enables the Blur w/o an option.  Did we decide if want an option to turn this off?


Index: MainWindow.cpp
===================================================================
--- MainWindow.cpp	(revision 1143496)
+++ MainWindow.cpp	(working copy)
@@ -57,6 +57,12 @@
 #include "ViewManager.h"
 #include "ViewSplitter.h"
 
+#ifdef Q_WS_X11
+#include <QX11Info>
+#include <X11/Xlib.h>
+#include <X11/Xatom.h>
+#endif
+
 using namespace Konsole;
 
 static bool useTransparency()
@@ -76,6 +82,12 @@
     if (useTransparency()) {
         setAttribute(Qt::WA_TranslucentBackground);
         setAttribute(Qt::WA_NoSystemBackground, false);
+#ifdef Q_WS_X11
+        Atom net_wm_blur_region = XInternAtom(QX11Info::display(), "_KDE_NET_WM_BLUR_BEHIND_REGION", False);
+        unsigned long region[] = { 0 };
+        XChangeProperty(QX11Info::display(), winId(), net_wm_blur_region, XA_CARDINAL, 32, PropModeReplace,
+                        reinterpret_cast<const unsigned char*>(&region), 1);
+#endif
     }
 
     // create actions for menus



- Kurt


On 2010-06-13 13:57:43, Arno Rehn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4292/
> -----------------------------------------------------------
> 
> (Updated 2010-06-13 13:57:43)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch adds an option to Konsole's color scheme editor to enable blurring on transparent backgrounds. It makes use of the new _KDE_NET_WM_BLUR_BEHIND_REGION Atom recognized by KWin.
> When tabs are switched it checks whether the color scheme of the new tab has blurring enabled and enables or disables blurring accordingly.
> 
> I know we're in hard feature freeze and string freeze. But to not have this forgotten, I'll post it here now.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/ColorScheme.h 1137325 
>   /trunk/KDE/kdebase/apps/konsole/src/ColorScheme.cpp 1137325 
>   /trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.h 1137325 
>   /trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.cpp 1137325 
>   /trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.ui 1137325 
>   /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.h 1137325 
>   /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1137325 
>   /trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp 1137325 
> 
> Diff: http://reviewboard.kde.org/r/4292/diff
> 
> 
> Testing
> -------
> 
> Tested by switching tabs back and forth, enabling and disabling blurring again and again. No crashes so far.
> 
> 
> Screenshots
> -----------
> 
> Konsole with enabled blurring
>   http://reviewboard.kde.org/r/4292/s/430/
> 
> 
> Thanks,
> 
> Arno
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20100629/b3c319b6/attachment.html>