[Konsole-devel] Review Request: Add option to blur transparent background (utilizing KWin's new blur support).

[Arno Rehn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4292/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

This patch adds an option to Konsole's color scheme editor to enable blurring on transparent backgrounds. It makes use of the new _KDE_NET_WM_BLUR_BEHIND_REGION Atom recognized by KWin.
When tabs are switched it checks whether the color scheme of the new tab has blurring enabled and enables or disables blurring accordingly.

I know we're in hard feature freeze and string freeze. But to not have this forgotten, I'll post it here now.


Diffs
-----

  /trunk/KDE/kdebase/apps/konsole/src/ColorScheme.h 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ColorScheme.cpp 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.h 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.cpp 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ColorSchemeEditor.ui 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.h 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1137325 
  /trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp 1137325 

Diff: http://reviewboard.kde.org/r/4292/diff


Testing
-------

Tested by switching tabs back and forth, enabling and disabling blurring again and again. No crashes so far.


Screenshots
-----------

Konsole with enabled blurring
  http://reviewboard.kde.org/r/4292/s/430/


Thanks,

Arno