[Konsole-devel] Review Request: Make Konsole tab drags snap the position of click to mouse cursor

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4180/#review5948
-----------------------------------------------------------


Looks good to me.  We should likely wait until trunk is re-opened for 4.6 to apply.

- Kurt


On 2010-05-30 17:35:21, Shaun Reich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4180/
> -----------------------------------------------------------
> 
> (Updated 2010-05-30 17:35:21)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Hello, 
> 
> This patch makes konsole's tab dragging respond more smoothly.
> 
> Before this patch:
> 
> When the mouse was held down and dragged, regardless of where on the tab the mouse was clicked, the origin of the pixmap of the tab would follow the mouse cursor. This meant that if say ... you dragged the mouse on the center of the tab, as soon as the drag is recognized, the tab will "jump" to the mouse position, but the top-left corner of the pixmap will be following the cursor. 
> 
> After the patch:
> 
> The pixmap will follow the mouse cursor at the position that it was dragged. So if you start the drag at the center of the tab (x position), then that position of the pixmap will lock to the mouse position.
> 
> I probably did a terrible job at explaining it. But anyways, this makes it feel more natural.
> 
> I alsp upped the size of the indicator from 22px to 32px, since I felt like it was difficult to see - partially due to this change.
> 
> Let me know what you think.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp 1132072 
> 
> Diff: http://reviewboard.kde.org/r/4180/diff
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Shaun
> 
>