[Konsole-devel] Review Request: Make Shift+Up/Down/PgUp/PgDown keys handling a bit smarter

[Valentine Sinitsyn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4200/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

Currently, Konsole uses Shift+Up/Down/PageUp/PageDown keys internally to scroll the screen buffer and doesn't pass the appropriate keycodes to the program running in the terminal. There is nothing wrong with that, although some console programs (Midnight Commander and Screen, to name a few) may employ their own scrolling mechanisms, so they are interested in receiving these keypresses.

In order to satisfy both worlds, one can still use Shift+Up/Down/... for scrolling Konsole buffer, but only if there is anything to scroll. If there is nothing (as it would normally be with any console program with its own scrolling capabilities), keypresses should be passed unmodified to the program running in terminal.

The suggested patch implements this idea. It is compatible with both KDE 4.4.3 and trunk.


Diffs
-----

  trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1133265 

Diff: http://reviewboard.kde.org/r/4200/diff


Testing
-------

Yes. I'm using it on my systems for some days now.


Thanks,

Valentine