[Konsole-devel] Review Request: Allow Konsole to intelligently handle dropped files

[Frank Roscher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4600/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

With this patch Konsole creates a popup menu when a file from e.g. Dolphin has been dragged'n'dropped to it.
The popup menu allows to Copy, Move or Link the file into the current working directory or to simply paste its URL as text (the latter being the current behaviour in KDE4).

The popup is created using the same method that is used by dolphin, so there shouldn't be any concern about code duplication.
I'm not quite sure if this is the most elegant solution, especially with regard to my use of the sender() method. Please enlighten me if there's a better way :)

There was a (different) implementation for this back in KDE3 times; there's also a pretty popular wishlist item on the KDE forums.


Diffs
-----

  trunk/KDE/kdebase/apps/konsole/src/CMakeLists.txt 1148641 
  trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1148641 
  trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.h 1148641 
  trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1148641 

Diff: http://reviewboard.kde.org/r/4600/diff


Testing
-------

All possible operations in the popup with files and folders; local as well as over SFTP, single files as well as multiple files at once.
Dropping simple text still works, as well.
But I do tend to miss obvious stuff sometimes.


Screenshots
-----------

Popup menu
  http://reviewboard.kde.org/r/4600/s/456/


Thanks,

Frank

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20100711/03c2ceb3/attachment.html>