[Konsole-devel] Review Request: Allow tab width and text to be displayed as much as possible
Matthew Woehlke
mw_triad at users.sourceforge.net
Thu Jan 21 17:11:35 UTC 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2503/#review3778
-----------------------------------------------------------
/trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp
<http://reviewboard.kde.org/r/2503/#comment3200>
As has been mentioned elsewhere, please use a constant rather than a hard-coded number.
Also, please avoid introducing trailing whitespace.
- Matthew
On 2010-01-05 05:17:55, Kurt Hindenburg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2503/
> -----------------------------------------------------------
>
> (Updated 2010-01-05 05:17:55)
>
>
> Review request for Konsole.
>
>
> Summary
> -------
>
> This changes the hint size for the tab and automatically allows for the tab title to be elided.
>
> Part of patch is from BR157201
>
>
> This addresses bug 157201.
> https://bugs.kde.org/show_bug.cgi?id=157201
>
>
> Diffs
> -----
>
> /trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp 1069228
>
> Diff: http://reviewboard.kde.org/r/2503/diff
>
>
> Testing
> -------
>
> Tested under trunk using %d %D with varying folder lengths and tabs.
>
> I don't care much for the sizeHint code but it works. May have to redo it.
>
>
> Thanks,
>
> Kurt
>
>
More information about the konsole-devel
mailing list