[Konsole-devel] Review Request: Hide the menubar when in fullscreen mode

[Sascha Peilicke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2857/#review4119
-----------------------------------------------------------


I don't like this as this would ignore the "Show Menu Bar" settings entry. The menu bar can be hidden via settings already, that way it remains user configurable

- Sascha


On 2010-02-08 01:02:11, Trever Fischer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2857/
> -----------------------------------------------------------
> 
> (Updated 2010-02-08 01:02:11)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch automatically hides menubar when in fullscreen mode. When you move the mouse, the menubar pops back for a few seconds and hides again. With the tab bar at the bottom hidden, it makes for a very nice fullscreen terminal.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/MainWindow.h 1086846 
>   /trunk/KDE/kdebase/apps/konsole/src/MainWindow.cpp 1086846 
> 
> Diff: http://reviewboard.kde.org/r/2857/diff
> 
> 
> Testing
> -------
> 
> Used it for a day or so with and without fullscreen enabled.
> 
> 
> Thanks,
> 
> Trever
> 
>