[Konsole-devel] [Bug 188528] konsole's history adds spaces to end of lines when copying text

[Stéphane Messerli]

https://bugs.kde.org/show_bug.cgi?id=188528





--- Comment #53 from Orion Poplawski <orion cora nwra com>  2010-07-19 19:37:16 ---
I'm sorry.  This part of the patch was clearly wrong and needed in certain
situations:

@@ -1230,19 +1223,6 @@
         Character* data = screenLines[screenLine].data();
         int length = screenLines[screenLine].count();

-        // Don't remove end spaces in lines that wrap
-        if (!(lineProperties[screenLine] & LINE_WRAPPED))
-        {
-            // ignore trailing white space at the end of the line
-            for (int i = length-1; i >= 0; i--)
-            {
-                if (data[i].character == ' ')
-                    length--;
-                else
-                    break;
-            }
-        }
- 
         //retrieve line from screen image
         for (int i=start;i < qMin(start+count,length);i++)
         {

Please restore.

--- Comment #54 from Stéphane Messerli <stephane messerli 247realmedia com>  2010-08-05 15:55:17 ---
Hi all,

I confirm that Konsole is not adding spaces at the end of lines copied from the
history in the newest Mandriva 2010.1 version, this bug has been fixed.
 - Konsole version 2.4.3
 - KDE version 4.4.3

Thanks!
- Stéphane

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.