[Konsole-devel] Review Request: Patch for command-line option to read tab titles and tab commands from file

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1079/#review5248
-----------------------------------------------------------


I looked at this more closely to see if we can get it in 4.5.  I changed a bunch of stuff.  I created a BR and attached a patch there.
If you have time, please comment on it.

- Kurt


On 2009-12-14 09:01:35, Thomas Dreibholz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1079/
> -----------------------------------------------------------
> 
> (Updated 2009-12-14 09:01:35)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The attached patch introduces the new command line option "-tabsfromfile <filename>" to konsole. On startup, konsole reads the file which contains one line for each tab to be created. Syntax is "<tab title>: <command> <args> ..."; comment lines start with '#'. This new option can e.g. be used to conveniently open ssh connections to a pool of PCs; with one tab for each PC. Such a configuration file could look like this:
> # SSH sessions to all Network Testbed PCs
> Control: ssh -CX user at control.my-domain.org
> West:    ssh -CX user at west.my-domain.org
> North:   ssh -CX user at north.my-domain.org
> South:   ssh -CX user at south.my-domain.org
> East:    ssh -CX user at east.my-domain.org
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/Application.h 1062212 
>   /trunk/KDE/kdebase/apps/konsole/src/Application.cpp 1062212 
>   /trunk/KDE/kdebase/apps/konsole/src/main.cpp 1062212 
> 
> Diff: http://reviewboard.kde.org/r/1079/diff
> 
> 
> Testing
> -------
> 
> Tested against SVN revision 1062216. No problems found with Valgrind.
> 
> 
> Thanks,
> 
> Thomas
> 
>