[Konsole-devel] Review Request: Added "Copy To All Tabs" feature for konsole

[Kurt Hindenburg]

> On 2009-09-24 04:07:48, Kurt Hindenburg wrote:
> > As far as I can tell, it works as expected.  I would say commit it.  The  shortcut ctrl+shift+^ doesn't work on my systems.  
> > A minor nit-pick, don't include non-code changes in your patches (ie. spaces/tabs/newlines/etc).  I noticed this with your other  patches as well.  Although thank you very much for the patches.
> 
> Robert Knight wrote:
>     Hi Kurt - If you're happy with the patch please go ahead and commit it or Thomas, if you have SVN access then please feel free to commit.

One thing I noticed, if you are not using the 2nd parameter in the  connectPair/disconnectPair() perhaps you should remove them entirely?


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1056/#review2452
-----------------------------------------------------------


On 2009-09-22 17:56:19, Thomas Dreibholz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1056/
> -----------------------------------------------------------
> 
> (Updated 2009-09-22 17:56:19)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> konsole in KDE <4.0 had the really convenient feature to send input to all tabs of the same konsole window. KDE 4.x's konsole lacks of this feature. Instead, the "Copy Input To" feature requires to select sessions. Unfortunately, the sessions are not hierachically sorted. So, if opening many sessions (many tabs in many konsole windows) -- e.g. I usually have about 20 to 40 tabs in different windows on 8 screens open -- it is very time-consuming and annoying to find and select/deselect the right session in the "Copy Input To" dialog. On an old KDE 3.5 system, it has been possible to activate/deactivate copying to all tabs of the current window with a single keyboard shortcut. This has been very convenient when managing a pool of PCs by having one konsole window for the pool, with a tab for each SSH connection to one of the PCs. The lack of this KDE 3 feature has prevented me from upgrading my systems to KDE 4.x yet. In order to overcome this problem, the attached patch adds a "Copy To All Tabs" feature to konsole. It works as follows:
> - If "Copy To All Tabs" is activated, "Copy Input To" settings are deactivated and the input is forwarded to all sessions in the same window.
> - If "Copy To All Tabs" is deactivated, the input only goes into the current session.
> - If "Copy Input To" is used when "Copy To All Tabs" is activated, the currently activated sessions are used for the "Copy Input To" dialog which allows for modifying the settings. "Copy To All Tabs" is deactivated then; the settings of "Copy Input To" are used instead.
> 
> 
> This addresses bug 168292.
>     https://bugs.kde.org/show_bug.cgi?id=168292
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 1026725 
>   /trunk/KDE/kdebase/apps/konsole/src/Session.h 1026725 
>   /trunk/KDE/kdebase/apps/konsole/src/Session.cpp 1026725 
>   /trunk/KDE/kdebase/apps/konsole/src/SessionController.h 1026725 
>   /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 1026725 
> 
> Diff: http://reviewboard.kde.org/r/1056/diff
> 
> 
> Testing
> -------
> 
> Compiles against SVN trunk. Tested with SVN revision 1016710. Also checked with Valgrind.
> 
> 
> Thanks,
> 
> Thomas
> 
>