[Konsole-devel] Review Request: Fix scrollbar coloring when changing system colors

Christoph Feck christoph at maxiom.de
Wed Nov 11 22:13:49 UTC 2009



> On 2009-11-11 16:15:27, Kurt Hindenburg wrote:
> > Looks fine with me - I tested hiding the scrollbar and all seems to work.  Do you have a svn account?

Thanks for the review. Committed as r1047721.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2133/#review3031
-----------------------------------------------------------


On 2009-11-11 01:40:55, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2133/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 01:40:55)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> When changing the system colors, Konsole's TerminalDisplay does not respect the changed colors. This is because it forces the current Application palette on the scrollbar, but does not update on color changes. This patch fixes this.
> 
> 
> This addresses bug 170760.
>     https://bugs.kde.org/show_bug.cgi?id=170760
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1047278 
> 
> Diff: http://reviewboard.kde.org/r/2133/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>




More information about the konsole-devel mailing list