[Konsole-devel] Review Request: Fix scrollbar coloring when changing system colors

Kurt Hindenburg kurt.hindenburg at gmail.com
Wed Nov 11 15:13:15 UTC 2009



> On 2009-11-11 04:42:24, Kurt Hindenburg wrote:
> > It doesn't appear to work here.  I tried patching 4.3.3 and trunk.  New tabs will get the new scrollbar color but not tabs already opened.
> 
> Christoph Feck wrote:
>     Hm, that's odd. Did you restart Konsole? Just opening a new Konsole will not restart it, as the old process is still used.

You are correct.  A restart fixed it... 


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2133/#review3013
-----------------------------------------------------------


On 2009-11-11 01:40:55, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2133/
> -----------------------------------------------------------
> 
> (Updated 2009-11-11 01:40:55)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> When changing the system colors, Konsole's TerminalDisplay does not respect the changed colors. This is because it forces the current Application palette on the scrollbar, but does not update on color changes. This patch fixes this.
> 
> 
> This addresses bug 170760.
>     https://bugs.kde.org/show_bug.cgi?id=170760
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 1047278 
> 
> Diff: http://reviewboard.kde.org/r/2133/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph
> 
>




More information about the konsole-devel mailing list