[Konsole-devel] Review Request: fix for 'konsole tabs too wide'

Rastislav Stanik rastos+kdereviewboard at gmail.com
Tue May 19 19:58:45 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/721/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

The patch is a single line change fixing konsole bug #166573: minimum tab width is too wide.
The problem was that Qt 4.5 introduced a new property with name "expanding" and default value "true".
The fix is simply to force this property to "false" by calling "_tabBar->setExpanding(false);" at the place where the _tabBar is initialized. That results in tabs those that were used in KDE 3.x.


This addresses bug 166573.
    https://bugs.kde.org/show_bug.cgi?id=166573


Diffs
-----

  /trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp 970222 

Diff: http://reviewboard.kde.org/r/721/diff


Testing
-------


Thanks,

Rastislav




More information about the konsole-devel mailing list