[Konsole-devel] Review Request: Fix Konsole part to work with apps that use the old v1 TerminalInterface

Trever Fischer wm161 at wm161.net
Mon Mar 30 20:59:43 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/484/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

The recent change to TerminalInterfaceV2 in konsole's KPart caused yakuake to stop functioning properly. It would load up the KPart but when it got to qobject_cast<TerminalInterface>() in the constructor, it failed to return a proper terminal interface. This patch fixes it by making Qt take note that the KPart also implements TerminalInterface in addition to TerminalInterfaceV2


Diffs
-----

  trunk/KDE/kdebase/apps/konsole/src/Part.h 947070 

Diff: http://reviewboard.kde.org/r/484/diff


Testing
-------

After compiling this quick change, yakuake works again.


Thanks,

Trever




More information about the konsole-devel mailing list