[Konsole-devel] Review Request: KonsolePart loads wrong config file while running in Dolphin or Kate

[Rahman Duran]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/462/
-----------------------------------------------------------

(Updated 2009-03-29 06:05:36.864338)


Review request for Konsole.


Changes
-------

Thanks Robert, changed as you adviced.


Summary
-------

The reason of the bug: 
KSharedConfigPtr appConfig = KGlobal::config();
    const KConfigGroup group = appConfig->group( "Desktop Entry" );
    QString defaultSessionFilename =
group.readEntry("DefaultProfile","Shell.profile");

in this code "KSharedConfigPtr appConfig = KGlobal::config();" this line
returns the current apps config file. If you run Konsole, no problem, the
current app is Konsole so it loads konsolerc.desktop file. If you run in
Dolphin panel the current app is Dolphin so dolphinrc.desktop file is loaded.
In this case as there is no "DefaultProfile" entry in dolphinrc it returns
"Shell.profile" instead of default one.

The bug should be fixed easly. konsolePart should load konsolerc.desktop
instead of current app rc file.


This addresses bug 172034.
    https://bugs.kde.org/show_bug.cgi?id=172034


Diffs (updated)
-----

  trunk/KDE/kdebase/apps/konsole/src/SessionManager.cpp 946376 

Diff: http://reviewboard.kde.org/r/462/diff


Testing
-------


Thanks,

Rahman