[Konsole-devel] Review Request: KonsolePart loads wrong config file while running in Dolphin or Kate

[Robert Knight]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/462/#review677
-----------------------------------------------------------


Reading the documentation for KConfig::KConfig, it appears that we should be using KSharedConfig::openConfig() to open konsolerc instead and keeping the type of appConfig as KSharedConfig::Ptr

- Robert


On 2009-03-28 16:52:23, Rahman Duran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/462/
> -----------------------------------------------------------
> 
> (Updated 2009-03-28 16:52:23)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The reason of the bug: 
> KSharedConfigPtr appConfig = KGlobal::config();
>     const KConfigGroup group = appConfig->group( "Desktop Entry" );
>     QString defaultSessionFilename =
> group.readEntry("DefaultProfile","Shell.profile");
> 
> in this code "KSharedConfigPtr appConfig = KGlobal::config();" this line
> returns the current apps config file. If you run Konsole, no problem, the
> current app is Konsole so it loads konsolerc.desktop file. If you run in
> Dolphin panel the current app is Dolphin so dolphinrc.desktop file is loaded.
> In this case as there is no "DefaultProfile" entry in dolphinrc it returns
> "Shell.profile" instead of default one.
> 
> The bug should be fixed easly. konsolePart should load konsolerc.desktop
> instead of current app rc file.
> 
> 
> This addresses bug 172034.
>     https://bugs.kde.org/show_bug.cgi?id=172034
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/SessionManager.cpp 946251 
> 
> Diff: http://reviewboard.kde.org/r/462/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahman
> 
>